Make missing field exception public #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still cannot wrap my head around the proper solution for #1930, so it's unlikely to fit into 1.4.0 timeline |
shanshin
reviewed
Jul 6, 2022
core/commonMain/src/kotlinx/serialization/SerializationExceptions.kt
Outdated
Show resolved
Hide resolved
shanshin
reviewed
Jul 7, 2022
| val missedMessages = messages.filter { !exception.message!!.contains(it) } | ||
| private inline fun assertFailsWithMessages(fields: List<String>, block: () -> Unit) { | ||
| val exception = assertFailsWith(MissingFieldException::class, null, block) | ||
| val missedMessages = fields.filter { !exception.message!!.contains(it) } |
There was a problem hiding this comment.
M.b. missedFields?
Such a check is not very reliable !exception.message!!.contains(it), maybe always put names in single quotes and check !exception.message!!.contains("'$it'")
sandwwraith
approved these changes
Jul 8, 2022
formats/json-tests/jvmTest/src/kotlinx/serialization/JvmMissingFieldsExceptionTest.kt
Outdated
Show resolved
Hide resolved
|
What about |
…gFieldsExceptionTest.kt Co-authored-by: Leonid Startsev <[email protected]>
|
@sandwwraith I found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266